Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dark grey dropdown button #588

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Conversation

jkbktl
Copy link
Collaborator

@jkbktl jkbktl commented Oct 1, 2024

No description provided.

Copy link

changeset-bot bot commented Oct 1, 2024

🦋 Changeset detected

Latest commit: e7c0442

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@status-im/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 1, 2024

@jkbktl is attempting to deploy a commit to the Status Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
status-components ⬜️ Ignored (Inspect) Visit Preview Oct 1, 2024 5:09pm

Comment on lines +56 to +59
darkGrey: [
'text-neutral-100 dark:text-white-100',
'[&>path[fill="#E7EAEE"]]:dark:fill-neutral-80',
],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference of this variant to the grey one?

Copy link
Collaborator

@prichodko prichodko Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these styles affect the icon, button styles are in the <Button />

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind. I'm just tired. Makes total sense. I thought i was looking at <Button /> component. 🤦

@jkbktl jkbktl merged commit 273db4e into status-im:main Oct 1, 2024
3 checks passed
@jkbktl jkbktl deleted the fix/dropdown-button branch October 1, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants